Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK]persist input from run results to avoid input missing in run results #855

Merged
merged 2 commits into from
Oct 24, 2023
Merged

[SDK]persist input from run results to avoid input missing in run results #855

merged 2 commits into from
Oct 24, 2023

Conversation

D-W-
Copy link
Contributor

@D-W- D-W- commented Oct 23, 2023

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.
Before:
image
After:
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@D-W- D-W- requested a review from a team as a code owner October 23, 2023 09:01
@D-W- D-W- temporarily deployed to internal October 23, 2023 09:01 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 09:01 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 09:01 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 09:01 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 09:01 — with GitHub Actions Inactive
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK CLI Global Config Test Result wanhan/extract_inputs_from_line_results

2 tests   2 ✔️  43s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit fd36655.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Executor Unit Test Result wanhan/extract_inputs_from_line_results

    2 files      2 suites   1m 49s ⏱️
386 tests 385 ✔️ 1 💤 0 ❌
750 runs  747 ✔️ 3 💤 0 ❌

Results for commit fd36655.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK PFS E2E Test Result wanhan/extract_inputs_from_line_results

8 tests   8 ✔️  26s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit fd36655.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Executor E2E Test Result wanhan/extract_inputs_from_line_results

    2 files      2 suites   19m 30s ⏱️
108 tests 106 ✔️ 2 💤 0 ❌
216 runs  210 ✔️ 6 💤 0 ❌

Results for commit fd36655.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK CLI Test Result wanhan/extract_inputs_from_line_results

    2 files      2 suites   32m 4s ⏱️
306 tests 293 ✔️ 13 💤 0 ❌
612 runs  586 ✔️ 26 💤 0 ❌

Results for commit fd36655.

♻️ This comment has been updated with latest results.

@D-W- D-W- temporarily deployed to internal October 24, 2023 02:33 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 24, 2023 02:33 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 24, 2023 02:33 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 24, 2023 02:33 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 24, 2023 02:33 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 24, 2023 03:00 — with GitHub Actions Inactive
@D-W- D-W- merged commit ecf9d07 into main Oct 24, 2023
31 checks passed
@D-W- D-W- deleted the wanhan/extract_inputs_from_line_results branch October 24, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

Assignees
No one assigned
Labels
promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D-W- @zhengfeiwang @wangchao1230