Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove working_dir #857

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Remove working_dir #857

merged 1 commit into from
Oct 23, 2023

Conversation

Hhhilulu
Copy link
Contributor

Description

Remove working_dir parameter.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Hhhilulu Hhhilulu requested a review from a team as a code owner October 23, 2023 09:36
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 09:36 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 09:36 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 09:36 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 09:36 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 09:36 — with GitHub Actions Inactive
@github-actions
Copy link

SDK CLI Global Config Test Result luluzuo/remove_working_dir

2 tests   2 ✔️  41s ⏱️
1 suites  0 💤
1 files    0

Results for commit a360741.

@github-actions
Copy link

Executor Unit Test Result luluzuo/remove_working_dir

    2 files      2 suites   2m 13s ⏱️
386 tests 385 ✔️ 1 💤 0
750 runs  747 ✔️ 3 💤 0

Results for commit a360741.

@github-actions
Copy link

SDK PFS E2E Test Result luluzuo/remove_working_dir

8 tests   8 ✔️  24s ⏱️
1 suites  0 💤
1 files    0

Results for commit a360741.

@github-actions
Copy link

Executor E2E Test Result luluzuo/remove_working_dir

    2 files      2 suites   6m 34s ⏱️
108 tests 106 ✔️ 2 💤 0
216 runs  210 ✔️ 6 💤 0

Results for commit a360741.

@Hhhilulu Hhhilulu changed the title remove working_dir Remove working_dir Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

SDK CLI Test Result luluzuo/remove_working_dir

    2 files      2 suites   25m 16s ⏱️
305 tests 292 ✔️ 13 💤 0
610 runs  584 ✔️ 26 💤 0

Results for commit a360741.

♻️ This comment has been updated with latest results.

@Hhhilulu Hhhilulu temporarily deployed to internal October 23, 2023 09:57 — with GitHub Actions Inactive
@Hhhilulu Hhhilulu merged commit 8dfb81a into main Oct 23, 2023
31 checks passed
@Hhhilulu Hhhilulu deleted the luluzuo/remove_working_dir branch October 23, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants