Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BufFix] Redact data when printing secret in the node #860

Merged
merged 8 commits into from
Oct 26, 2023
Merged

[BufFix] Redact data when printing secret in the node #860

merged 8 commits into from
Oct 26, 2023

Conversation

Jasmin3q
Copy link
Contributor

@Jasmin3q Jasmin3q commented Oct 23, 2023 •
edited
Loading

Description

[BUG] [VSCode Extension] secrets in CustomConnection are not redacted when we print it
Add connection secret to context credential list, so that all the secret which is printed during the flow run and node run will be redacted as data_scrubbed.

local test result:
for flow.dag:
1698054488148
flow run:
1698054650556
node run:
1698054591865

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Jasmin3q Jasmin3q added the bug Something isn't working label Oct 23, 2023
@Jasmin3q Jasmin3q requested a review from a team as a code owner October 23, 2023 09:54
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 09:54 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 09:54 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 09:54 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 09:54 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 09:54 — with GitHub Actions Inactive
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK CLI Global Config Test Result shimin/fix_data_scrub

2 tests   2 ✔️  46s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 60fcd17.

♻️ This comment has been updated with latest results.

@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 09:58 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 09:58 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 09:58 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 09:58 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 09:58 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q force-pushed the shimin/fix_data_scrub branch from 4ffd5e1 to 1b2b816 Compare October 23, 2023 10:03
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 10:03 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 10:03 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 10:03 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 10:03 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 10:03 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q force-pushed the shimin/fix_data_scrub branch from 1b2b816 to 79e6508 Compare October 23, 2023 10:06
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 10:06 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 10:06 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 10:06 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 10:06 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 23, 2023 10:07 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK PFS E2E Test Result shimin/fix_data_scrub

8 tests   8 ✔️  35s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 60fcd17.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Executor Unit Test Result shimin/fix_data_scrub

377 tests   376 ✔️  48s ⏱️
    1 suites      1 💤
    1 files        0 ❌

Results for commit 60fcd17.

♻️ This comment has been updated with latest results.

thy09
thy09 previously approved these changes Oct 25, 2023
View reviewed changes
@thy09 thy09 linked an issue Oct 25, 2023 that may be closed by this pull request
[BUG] [VSCode Extension] secrets in CustomConnection are not redacted when we print it #718
Closed
@Jasmin3q Jasmin3q dismissed stale reviews from thy09 and guming-learning via fac75dd October 25, 2023 13:03
@Jasmin3q Jasmin3q temporarily deployed to internal October 25, 2023 13:03 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 25, 2023 13:03 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 25, 2023 13:03 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 25, 2023 13:03 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 25, 2023 13:03 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result shimin/fix_data_scrub

    2 files    2 suites   52s ⏱️
  58 tests 36 ✔️ 22 💤 0 ❌
116 runs  72 ✔️ 44 💤 0 ❌

Results for commit 60fcd17.

♻️ This comment has been updated with latest results.

@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 02:42 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 03:06 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 03:06 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 03:06 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 03:06 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 03:06 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 07:05 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 07:05 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 07:05 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 07:05 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q temporarily deployed to internal October 26, 2023 07:05 — with GitHub Actions Inactive
@Jasmin3q Jasmin3q merged commit 4edec58 into main Oct 26, 2023
32 checks passed
@Jasmin3q Jasmin3q deleted the shimin/fix_data_scrub branch October 26, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guming-learning guming-learning guming-learning approved these changes

@thy09 thy09 thy09 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [VSCode Extension] secrets in CustomConnection are not redacted when we print it
3 participants
@Jasmin3q @thy09 @guming-learning