Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK]flow as func POC #861

Merged
merged 30 commits into from
Nov 2, 2023
Merged

[SDK]flow as func POC #861

merged 30 commits into from
Nov 2, 2023

Conversation

D-W-
Copy link
Contributor

@D-W- D-W- commented Oct 23, 2023 •
edited
Loading

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

This PR implements flow-as-func to support simple serve scenario, reference tutorials/flow-deploy/create-service-with-flow for sample usage.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@D-W- D-W- requested a review from a team as a code owner October 23, 2023 10:33
@D-W- D-W- temporarily deployed to internal October 23, 2023 10:33 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 10:33 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 10:33 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 10:33 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 10:33 — with GitHub Actions Inactive
@github-actions github-actions bot added examples Improvements on examples sdk prompt flow SDK promptflow labels Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK CLI Global Config Test Result wanhan/flow_as_func

2 tests   2 ✔️  47s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit c83d4eb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK PFS E2E Test Result wanhan/flow_as_func

8 tests   8 ✔️  46s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit c83d4eb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Executor Unit Test Result wanhan/flow_as_func

413 tests   413 ✔️  53s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit c83d4eb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Executor E2E Test Result wanhan/flow_as_func

127 tests   125 ✔️  1m 54s ⏱️
    1 suites      2 💤
    1 files        0 ❌

Results for commit c83d4eb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK CLI Test Result wanhan/flow_as_func

331 tests   319 ✔️  16m 43s ⏱️
    1 suites    12 💤
    1 files        0 ❌

Results for commit c83d4eb.

♻️ This comment has been updated with latest results.

@D-W- D-W- temporarily deployed to internal October 24, 2023 02:32 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 24, 2023 02:32 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 24, 2023 02:32 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 24, 2023 02:32 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 24, 2023 02:32 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 31, 2023 08:24 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 31, 2023 08:24 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 31, 2023 08:24 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 31, 2023 08:24 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 31, 2023 08:24 — with GitHub Actions Inactive
wangchao1230
wangchao1230 previously approved these changes Oct 31, 2023
View reviewed changes
@D-W- D-W- temporarily deployed to internal November 1, 2023 15:22 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal November 1, 2023 15:22 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal November 1, 2023 15:22 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal November 1, 2023 15:22 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal November 1, 2023 15:22 — with GitHub Actions Inactive
wangchao1230
wangchao1230 previously approved these changes Nov 2, 2023
View reviewed changes
@D-W- D-W- temporarily deployed to internal November 2, 2023 00:55 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal November 2, 2023 00:55 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal November 2, 2023 00:55 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal November 2, 2023 00:55 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal November 2, 2023 00:55 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal November 2, 2023 01:16 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal November 2, 2023 02:01 — with GitHub Actions Inactive
@D-W- D-W- merged commit ef22b0f into main Nov 2, 2023
43 checks passed
@D-W- D-W- deleted the wanhan/flow_as_func branch November 2, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

Assignees
No one assigned
Labels
examples Improvements on examples promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D-W- @zhengfeiwang @wangchao1230