Skip to content

Fixed bug that results in a false positive "missing stub file" diagno…#10205

Merged
erictraut merged 1 commit intomainfrom
issue-10203
Mar 29, 2025
Merged

Fixed bug that results in a false positive "missing stub file" diagno…#10205
erictraut merged 1 commit intomainfrom
issue-10203

Conversation

@erictraut
Copy link
Copy Markdown
Collaborator

…stic when importing a "py.typed" submodule from a namespace package. This addresses #10203.

…stic when importing a "py.typed" submodule from a namespace package. This addresses #10203.
@github-actions
Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

sympy (https://github.com/sympy/sympy)
-   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:170:41 - error: Argument of type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" cannot be assigned to parameter "expr" of type "ArrayDiagonal" in function "_array_diag2contr_diagmatrix"
-     Type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" is not assignable to type "ArrayDiagonal"
-       "Basic" is not assignable to "ArrayDiagonal" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:174:41 - error: Argument of type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" cannot be assigned to parameter "expr" of type "ArrayDiagonal" in function "_array_diag2contr_diagmatrix"
-     Type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" is not assignable to type "ArrayDiagonal"
-       "Basic" is not assignable to "ArrayDiagonal" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:180:41 - error: Argument of type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" cannot be assigned to parameter "expr" of type "ArrayDiagonal" in function "_array_diag2contr_diagmatrix"
-     Type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" is not assignable to type "ArrayDiagonal"
-       "Basic" is not assignable to "ArrayDiagonal" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:184:41 - error: Argument of type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" cannot be assigned to parameter "expr" of type "ArrayDiagonal" in function "_array_diag2contr_diagmatrix"
-     Type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" is not assignable to type "ArrayDiagonal"
-       "Basic" is not assignable to "ArrayDiagonal" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:188:41 - error: Argument of type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" cannot be assigned to parameter "expr" of type "ArrayDiagonal" in function "_array_diag2contr_diagmatrix"
-     Type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" is not assignable to type "ArrayDiagonal"
-       "Basic" is not assignable to "ArrayDiagonal" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:196:41 - error: Argument of type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" cannot be assigned to parameter "expr" of type "ArrayDiagonal" in function "_array_diag2contr_diagmatrix"
-     Type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" is not assignable to type "ArrayDiagonal"
-       "Basic" is not assignable to "ArrayDiagonal" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:205:41 - error: Argument of type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" cannot be assigned to parameter "expr" of type "ArrayDiagonal" in function "_array_diag2contr_diagmatrix"
-     Type "Unknown | Zero | ZeroArray | ArrayContraction | Basic | PermuteDims | ArrayAdd | ArrayDiagonal" is not assignable to type "ArrayDiagonal"
-       "Basic" is not assignable to "ArrayDiagonal" (reportArgumentType)
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:213:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayDiagonal"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:213:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayAdd"
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:217:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayDiagonal"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:217:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayAdd"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:223:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayDiagonal"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:223:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayAdd"
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:227:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayDiagonal"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:227:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayAdd"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:231:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayDiagonal"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:231:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayAdd"
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:235:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayDiagonal"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:235:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayAdd"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:241:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayDiagonal"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:241:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayAdd"
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:245:39 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayDiagonal"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:245:39 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayAdd"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:249:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayDiagonal"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:249:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayAdd"
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:255:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayDiagonal"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/tensor/array/expressions/tests/test_convert_array_to_matrix.py:255:15 - error: Cannot access attribute "split_multiple_contractions" for class "ArrayAdd"
+     Attribute "split_multiple_contractions" is unknown (reportAttributeAccessIssue)

... (truncated 266 lines) ...

@erictraut erictraut merged commit de7f419 into main Mar 29, 2025
18 checks passed
@erictraut erictraut deleted the issue-10203 branch March 29, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant