Skip to content

Use shared helper method to call python interpreter to have consistent behavior between different calls.#2581

Merged
heejaechang merged 1 commit into
microsoft:mainfrom
heejaechang:pythonVersion
Nov 18, 2021
Merged

Use shared helper method to call python interpreter to have consistent behavior between different calls.#2581
heejaechang merged 1 commit into
microsoft:mainfrom
heejaechang:pythonVersion

Conversation

@heejaechang

Copy link
Copy Markdown
Collaborator

fixes #2562

@erictraut

Copy link
Copy Markdown
Collaborator

LGTM

@heejaechang

Copy link
Copy Markdown
Collaborator Author

thank you @erictraut

...

I just confirmed that it now calls through new code path for ensurePythonVersion when pyproject.toml exists.

@heejaechang heejaechang marked this pull request as ready for review November 18, 2021 05:59
@heejaechang heejaechang merged commit 121c808 into microsoft:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pyright with venv still uses Python 2.7 on MacOS

2 participants