Skip to content

Use shared helper method to call python interpreter to have consistent behavior between different calls. #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2021
Merged

Use shared helper method to call python interpreter to have consistent behavior between different calls. #2581

merged 1 commit into from
Nov 18, 2021

Conversation

heejaechang
Copy link
Collaborator

fixes #2562

@erictraut
Copy link
Collaborator

LGTM

@heejaechang
Copy link
Collaborator Author

thank you @erictraut

...

I just confirmed that it now calls through new code path for ensurePythonVersion when pyproject.toml exists.

@heejaechang heejaechang marked this pull request as ready for review November 18, 2021 05:59
@heejaechang heejaechang merged commit 121c808 into microsoft:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pyright with venv still uses Python 2.7 on MacOS
2 participants
@heejaechang @erictraut