Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically import smol-toml package #9463

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

heejaechang
Copy link
Collaborator

@heejaechang heejaechang commented Nov 14, 2024

module change in tsconfig.json in 6be5f8c#diff-ac3a7b49798141e77c54e96bca892a082469cc83bb335322b35c01e020b060c8R1142 is causing issues in pylance due to it supporting multiple environments such as webpack, ts-node, browser and etc.

this is another approach to use smol-toml. confirmed it works as expected with webpack, ts-node and etc.

This comment has been minimized.

Copy link
Collaborator

@erictraut erictraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears to break pyright. Refer to the mypy_primer output. All of the projects that use pyproject.toml are reporting errors now.

@heejaechang
Copy link
Collaborator Author

@erictraut can you take a look again?

This comment has been minimized.

Copy link
Collaborator

@erictraut erictraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but it would be better if the "shared.ts" file had a more appropriate and descriptive name.

packages/pyright-internal/src/common/shared.ts Outdated Show resolved Hide resolved
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@heejaechang heejaechang merged commit 7b8ce24 into microsoft:main Nov 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants