-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically import smol-toml package #9463
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change appears to break pyright. Refer to the mypy_primer output. All of the projects that use pyproject.toml are reporting errors now.
@erictraut can you take a look again? |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, but it would be better if the "shared.ts" file had a more appropriate and descriptive name.
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
module
change intsconfig.json
in 6be5f8c#diff-ac3a7b49798141e77c54e96bca892a082469cc83bb335322b35c01e020b060c8R1142 is causing issues in pylance due to it supporting multiple environments such as webpack, ts-node, browser and etc.this is another approach to use
smol-toml
. confirmed it works as expected with webpack, ts-node and etc.