-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mimalloc is vendored instead of fetched #1320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Benchmark for 4faef03Click to view benchmark
|
Benchmark for 8f07453Click to view benchmark
|
minestarks
reviewed
Mar 28, 2024
minestarks
reviewed
Mar 28, 2024
swernli
reviewed
Mar 28, 2024
swernli
approved these changes
Mar 28, 2024
minestarks
approved these changes
Mar 28, 2024
Benchmark for bb4a6edClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes copy a snapshot of the Mimalloc source from
v2.1.2
into the mimalloc-sys folder so that we no longer need to use cmake to fetch and prepare the source. This also fixesaarch64
Windows cross-compilation issues caused by cmake generators.I have addressed all DevSkim feedback and nothing was applicable or actionable.
I've run the release build and everything compiles. It shows a red X in the checks as I cancelled the second half of the build to prevent the release from going out.
Closes #1281