feat: Add Azure RBAC condition parser - #496
Merged
Anand Krishnamoorthi (anakrish) merged 2 commits intoNov 17, 2025
Merged
Conversation
Anand Krishnamoorthi (anakrish)
force-pushed
the
azure-rbac-conditions
branch
from
November 5, 2025 21:36
0d4a69e to
99baa0f
Compare
Anand Krishnamoorthi (anakrish)
marked this pull request as ready for review
November 5, 2025 21:55
Anand Krishnamoorthi (anakrish)
force-pushed
the
azure-rbac-conditions
branch
2 times, most recently
from
November 15, 2025 00:27
41bdc33 to
886e04b
Compare
- declare an `azure-rbac` feature and expose the Azure RBAC module with parser, AST, and YAML-driven tests - extend the shared lexer with RBAC-specific tokens, single-quoted strings, and corrected raw-string spans - verify the parser via comprehensive test cases covering every operator and complex chaining Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
Anand Krishnamoorthi (anakrish)
force-pushed
the
azure-rbac-conditions
branch
from
November 15, 2025 00:29
886e04b to
728d0f3
Compare
Denis Komissarov (dekomissMSFT)
previously approved these changes
Nov 15, 2025
Denis Komissarov (dekomissMSFT)
left a comment
Collaborator
There was a problem hiding this comment.
![]()
Anand Krishnamoorthi (anakrish)
dismissed stale reviews from David Pokluda (dpokluda) and Denis Komissarov (dekomissMSFT)
via
November 15, 2025 01:39
87cf1b2
Collaborator
Author
|
Denis Komissarov (@dekomissMSFT), I have addressed your PR feedback. |
Anand Krishnamoorthi (anakrish)
force-pushed
the
azure-rbac-conditions
branch
from
November 15, 2025 01:44
87cf1b2 to
752522f
Compare
- Add more parse error tests - Test rbac in github workflows - Simplify rego parser's token text function to not need feature flags. Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
Anand Krishnamoorthi (anakrish)
force-pushed
the
azure-rbac-conditions
branch
from
November 17, 2025 15:15
752522f to
d02c796
Compare
Anand Krishnamoorthi (anakrish)
merged commit Nov 17, 2025
ad8c543
into
microsoft:main
41 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
azure-rbacfeature and expose the Azure RBAC module with parser, AST, and YAML-driven tests