Skip to content

feat: Add Azure RBAC condition parser - #496

Merged
Anand Krishnamoorthi (anakrish) merged 2 commits into
microsoft:mainfrom
anakrish:azure-rbac-conditions
Nov 17, 2025
Merged

feat: Add Azure RBAC condition parser#496
Anand Krishnamoorthi (anakrish) merged 2 commits into
microsoft:mainfrom
anakrish:azure-rbac-conditions

Conversation

@anakrish

Copy link
Copy Markdown
Collaborator
  • declare an azure-rbac feature and expose the Azure RBAC module with parser, AST, and YAML-driven tests
  • extend the shared lexer with RBAC-specific tokens, single-quoted strings, and corrected raw-string spans
  • verify the parser via comprehensive test cases covering every operator and complex chaining

Comment thread src/languages/azure_rbac/ast.rs Fixed
Comment thread src/languages/azure_rbac/parser.rs Fixed
- declare an `azure-rbac` feature and expose the Azure RBAC module with parser, AST, and YAML-driven tests
- extend the shared lexer with RBAC-specific tokens, single-quoted strings, and corrected raw-string spans
- verify the parser via comprehensive test cases covering every operator and complex chaining

Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
Comment thread src/languages/azure_rbac/test_cases.yaml
Comment thread src/parser.rs Outdated
Comment thread src/languages/azure_rbac/tests.rs

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dpokluda David Pokluda (dpokluda) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anakrish

Copy link
Copy Markdown
Collaborator Author

Denis Komissarov (@dekomissMSFT), I have addressed your PR feedback.

- Add more parse error tests
- Test rbac in github workflows
- Simplify rego parser's token text function to not need feature flags.

Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>

@dpokluda David Pokluda (dpokluda) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anakrish
Anand Krishnamoorthi (anakrish) merged commit ad8c543 into microsoft:main Nov 17, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants