feat: Detect incorrect multi-threaded use from c based ffi - #499
Merged
Anand Krishnamoorthi (anakrish) merged 1 commit intoNov 17, 2025
Merged
Conversation
Anand Krishnamoorthi (anakrish)
force-pushed
the
ffi-thread-safety
branch
4 times, most recently
from
November 8, 2025 02:04
2ffb382 to
1b37c84
Compare
Anand Krishnamoorthi (anakrish)
force-pushed
the
ffi-thread-safety
branch
4 times, most recently
from
November 17, 2025 18:12
3ab9d89 to
5634f90
Compare
Anand Krishnamoorthi (anakrish)
marked this pull request as ready for review
November 17, 2025 18:17
Collaborator
Author
Add runtime detection for shared handle misuse wrap the FFI engine handle with parking_lot::RwLock when the new contention_checks feature is enabled, surfacing a clear “handle is already in use” error instead of allowing undefined behavior keep the feature optional so no_std builds or environments that supply their own synchronization can opt out caution users that this guards the handle itself but does not make the engine’s operations globally thread-safe on its own Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
Anand Krishnamoorthi (anakrish)
force-pushed
the
ffi-thread-safety
branch
from
November 17, 2025 18:54
5634f90 to
6d97651
Compare
Anand Krishnamoorthi (anakrish)
merged commit Nov 17, 2025
688e612
into
microsoft:main
41 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.