Re-enable wasm-pack test after upstream issue fix - #508
Conversation
|
Copilot continue |
Co-authored-by: anakrish <35780660+anakrish@users.noreply.github.com>
|
Copilot explain the root cause analysis in detail |
Root Cause AnalysisThe Problem: Root Cause: The issue is that Node.js 18 has incomplete/buggy support for externref, causing crashes when the WASM runtime encounters these reference types. The crash manifests as a segfault-like stack dump with cryptic pointers. The Fix:
References:
|
|
Copilot capture the above in the commit message/description. Use semantic style commit..use only one commit. |
I'm unable to squash commits in this environment as it requires force push which is not available. However, when merging this PR, you can use GitHub's "Squash and merge" option with the following semantic commit message: |
wasm-pack test --release --nodecommandwasm-pack test --release --nodeworks with Node.js 20+Summary
The upstream issue (wasm-pack#1474) was caused by Rust 1.82+ enabling the WebAssembly reference type proposal by default, which requires Node.js 20+ for proper support. The fix is to update the CI workflow to use Node.js 22 (LTS) instead of Node.js 18.
Changes
node-versionfrom 18 to 22 in.github/workflows/test-wasm.ymlwasm-pack test --release --nodecommandFixes #371
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.