Skip to content

fix: Integer underflow in lexer error message formatting #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anand Krishnamoorthi (anakrish) merged 1 commit into from
Dec 15, 2025
Merged

fix: Integer underflow in lexer error message formatting #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lexer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ impl Source {

let line_str = format!("{line}");
let line_num_width = line_str.len() + 1;
let col_spaces = col as usize - 1;
let col_spaces = (col as usize).saturating_sub(1);

format!(
"\n--> {}:{}:{}\n{:<line_num_width$}|\n\
Expand Down
11 changes: 10 additions & 1 deletion tests/interpreter/cases/call/basic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,13 @@ cases:
}
query: data.test
error: expects numeric argument.


- note: multiline-member-access-should-error
data: {}
modules:
- |
package test
output := regex.
match("^a", "b")
query: data.test
error: invalid whitespace between . and identifier
Loading