Skip to content

feat: implement net.cidr_expand builtin - #525

Merged
Anand Krishnamoorthi (anakrish) merged 1 commit into
microsoft:mainfrom
tjons:tjons/feat-implement-net-cidr-expand
Dec 17, 2025
Merged

feat: implement net.cidr_expand builtin#525
Anand Krishnamoorthi (anakrish) merged 1 commit into
microsoft:mainfrom
tjons:tjons/feat-implement-net-cidr-expand

Conversation

@tjons

@tjons Tyler Schade (tjons) commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Implements net.cidr_expand from #96.

Anand Krishnamoorthi (@anakrish) the rvm implementation seems to have caused some issues with clippy checking lifetimes during precommit hooks:

123 - impl<'a> Serialize for BinarySetRef<'a> {
123 + impl Serialize for BinarySetRef<'_> {
    |

error: the following explicit lifetimes could be elided: 'a
   --> src/rvm/program/serialization/value.rs:138:6
    |
138 | impl<'a> Serialize for BinaryObjectRef<'a> {
    |      ^^                                ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
138 - impl<'a> Serialize for BinaryObjectRef<'a> {
138 + impl Serialize for BinaryObjectRef<'_> {
    |

error: the following explicit lifetimes could be elided: 'a
   --> src/rvm/program/serialization/value.rs:153:6
    |
153 | impl<'a> Serialize for BinaryEntryRef<'a> {
    |      ^^                               ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
153 - impl<'a> Serialize for BinaryEntryRef<'a> {
153 + impl Serialize for BinaryEntryRef<'_> {
    |

error: could not compile `regorus` (lib) due to 19 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `regorus` (lib test) due to 19 previous errors
error: failed to push some refs to 'github.com:tjons/regorus.git'

is this expected?

Signed-off-by: tjons <tylerschade99@gmail.com>
@tjons Tyler Schade (tjons) changed the title WIP: feat: implement net.cidr_expand builtin WIP: feat: implement net.cidr_expand builtin Dec 16, 2025
@anakrish

Copy link
Copy Markdown
Collaborator

Tyler Schade (@tjons) I haven't seen those errors. Let me check.

@anakrish

Copy link
Copy Markdown
Collaborator

Hey Tyler Schade (@tjons), I am not able to reproduce those clippy errors. Which toolchain are you on?

@tjons Tyler Schade (tjons) changed the title WIP: feat: implement net.cidr_expand builtin feat: implement net.cidr_expand builtin Dec 16, 2025
@tjons

Copy link
Copy Markdown
Contributor Author

Anand Krishnamoorthi (@anakrish) those were on 1.86.0-aarch64-unknown-linux-gnu. I upgraded to 1.89.0-aarch64-unknown-linux-gnu and they resolved, albeit with some new errors related to no_std and the thumbv7m-none-eabi target... I'm unsure what the cause is but I've managed to run the rest of the checks locally manually and this is now ready for review!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Tyler Schade (@tjons)

@anakrish
Anand Krishnamoorthi (anakrish) merged commit 8b84d4c into microsoft:main Dec 17, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants