feat(ffi): unwind safety: shield FFI entrypoints with panic guard - #546
Merged
Anand Krishnamoorthi (anakrish) merged 1 commit intoJan 21, 2026
Merged
Conversation
Anand Krishnamoorthi (anakrish)
force-pushed
the
unwind-safe
branch
4 times, most recently
from
January 20, 2026 21:07
a2da010 to
7397f83
Compare
This PR implements widely accepted Rust programming practices for dealing with panics across ABI (programming language) boundaries. - Add panic_guard.rs to wrap FFI calls and prevent panic across FFI/ABI boundary (undefined behavior). - Capture per-thread backtraces via a temporary panic hook - After a panic, subsequent invocations are poisoned. - Integrate with_unwind_guard across the engine, schema registry, and target registry exportis Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
Anand Krishnamoorthi (anakrish)
force-pushed
the
unwind-safe
branch
from
January 20, 2026 21:20
7397f83 to
c3a8b6a
Compare
Anand Krishnamoorthi (anakrish)
changed the title
Anand Krishnamoorthi (anakrish)
marked this pull request as ready for review
January 20, 2026 21:22
Anand Krishnamoorthi (anakrish)
requested review from
Denis Komissarov (dekomissMSFT) and
David Pokluda (dpokluda)
January 20, 2026 21:48
Anand Krishnamoorthi (anakrish)
merged commit Jan 21, 2026
80686d6
into
microsoft:main
41 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements widely accepted Rust programming practices for
dealing with panics across ABI (programming language) boundaries.