Create rush-resolver-cache-plugin #4892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
patmill
as code owners
iclanton
reviewed
Aug 16, 2024
rush-plugins/rush-resolver-cache-plugin/src/afterInstallAsync.ts
Outdated
Show resolved
Hide resolved
rush-plugins/rush-resolver-cache-plugin/src/afterInstallAsync.ts
Outdated
Show resolved
Hide resolved
rush-plugins/rush-resolver-cache-plugin/src/afterInstallAsync.ts
Outdated
Show resolved
Hide resolved
rush-plugins/rush-resolver-cache-plugin/src/afterInstallAsync.ts
Outdated
Show resolved
Hide resolved
rush-plugins/rush-resolver-cache-plugin/src/afterInstallAsync.ts
Outdated
Show resolved
Hide resolved
dmichon-msft
force-pushed
the
user/dmichon/rush-resolver-cache-plugin
branch
from
23ad85c to
f8e2eae
Compare
iclanton
approved these changes
Aug 22, 2024
dmichon-msft
force-pushed
the
user/dmichon/rush-resolver-cache-plugin
branch
from
a563c97 to
ee2b805
Compare
iclanton
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new plugin to Rush that generates a cache file for use by
@rushstack/webpack-workspace-resolve-plugin.Details
Handles scenarios currently encountered in rushstack, plus some other edge cases (pointer to local tgz).
How it was tested
Temporarily wired it into the
start-devworkflow within the workspace. Installed using the dev version of Rush to generate the cache file, then leveraged it inside of the webpack config for@rushstack/rush-liband validated that theDescriptionFilePluginfromenhanced-resolvewas no longer hit.Impacted documentation
This plugin, docs for
@rushstack/webpack-workspace-resolve-plugin.