-
Notifications
You must be signed in to change notification settings - Fork 643
fix(redis): treat ignorable Redis errors as warnings #5325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aramissennyeydd
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
aramissennyeydd:sennyeya/fix-redis-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(redis): treat ignorable Redis errors as warnings #5325
aramissennyeydd
wants to merge
8
commits into
microsoft:main
from
aramissennyeydd:sennyeya/fix-redis-error
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramissennyeydd
commented
Aug 27, 2025
rush-plugins/rush-redis-cobuild-plugin/src/RedisCobuildLockProvider.ts
Outdated
Show resolved
Hide resolved
aramissennyeydd
commented
Aug 27, 2025
rush-plugins/rush-redis-cobuild-plugin/src/RedisCobuildLockProvider.ts
Outdated
Show resolved
Hide resolved
aramissennyeydd
commented
Aug 27, 2025
rush-plugins/rush-redis-cobuild-plugin/src/RedisCobuildLockProvider.ts
Outdated
Show resolved
Hide resolved
iclanton
approved these changes
Aug 27, 2025
Signed-off-by: Aramis Sennyey <[email protected]>
Signed-off-by: Aramis Sennyey <[email protected]>
Signed-off-by: Aramis Sennyey <[email protected]>
Signed-off-by: Aramis Sennyey <[email protected]>
Signed-off-by: Aramis Sennyey <[email protected]>
Signed-off-by: Aramis Sennyey <[email protected]>
Signed-off-by: Aramis Sennyey <[email protected]>
2c7aaf5
to
85d78ef
Compare
@iclanton Is this good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've been seeing intermittent CI failures caused by messages like,
We know that the underlying library
@redis/client
handles retries but it looks like there is no.on('error'
handler to listen for retryable errors so it is crashing the process. This PR addresses that by adding an.on('error'
handler and configuring the retry strategy to give up after a couple of failed connection attempts (I chose 5 as a good number). This also necessitated bumping the package version to latest.Details
Added an
'error'
handler to prevent the entire process from crashing due to unhandled errors. This is hidden in the docs, https://github.com/redis/node-redis#events but is definitely causing issues for us.How it was tested
Ran the
rush-redis-cobuild-integration-test
locally anddocker-compose down
-ed the redis server halfway through a run. Before this change, the Rush process would immediately crash - with this change, if youdocker-compose up -d
again within the retryStrategy timeout, the process continues until success. If you keep the redis server off, the process will die with a message like,Impacted documentation