[bug] Fix app crash when doc references a citation that does not exist (

#414) Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
microsoft · Dec 4, 2023 · 9f92236 · 9f92236
1 parent 99bee96
commit 9f92236
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/frontend/src/components/Answer/AnswerParser.tsx b/frontend/src/components/Answer/AnswerParser.tsx
@@ -19,7 +19,7 @@ export function parseAnswer(answer: AskResponse): ParsedAnswer {
         // Replacing the links/citations with number
         let citationIndex = link.slice(lengthDocN, link.length - 1);
         let citation = cloneDeep(answer.citations[Number(citationIndex) - 1]) as Citation;
-        if (!filteredCitations.find((c) => c.id === citationIndex)) {
+        if (!filteredCitations.find((c) => c.id === citationIndex) && citation) {
           answerText = answerText.replaceAll(link, ` ^${++citationReindex}^ `);
           citation.id = citationIndex; // original doc index to de-dupe
           citation.reindex_id = citationReindex.toString(); // reindex from 1 for display

diff --git a/static/assets/index-f479a168.js → static/assets/index-4e24bac2.js b/static/assets/index-f479a168.js → static/assets/index-4e24bac2.js
diff --git a/static/assets/index-f479a168.js.map → static/assets/index-4e24bac2.js.map b/static/assets/index-f479a168.js.map → static/assets/index-4e24bac2.js.map
diff --git a/static/index.html b/static/index.html
@@ -5,7 +5,7 @@
     <link rel="icon" type="image/x-icon" href="/favicon.ico" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Azure AI</title>
-    <script type="module" crossorigin src="/assets/index-f479a168.js"></script>
+    <script type="module" crossorigin src="/assets/index-4e24bac2.js"></script>
     <link rel="stylesheet" href="/assets/index-5ba581b7.css">
   </head>
   <body>