Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to build process and startup scripts #1023

Closed
wants to merge 3 commits into from

Conversation

abhahn
Copy link
Member

@abhahn abhahn commented Jul 26, 2024

Motivation and Context

This PR makes 2 main changes:

  1. Change vite build options to not overwrite the static directory on build, which can cause custom images to be removed from this folder if they have been added.
  2. Create an option to skip the build in the startup scripts to save time if only making config or backend changes. The option is additive, so current users of these scripts will not notice the change unless the new option --skip-build is provided on the command line.

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

@abhahn abhahn marked this pull request as ready for review July 26, 2024 02:09
@abhahn
Copy link
Member Author

abhahn commented Aug 1, 2024

Moving docs to a separate PR, and abandoning startup script changes for now since a best practice for building with custom logos has been identified.

@abhahn abhahn closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant