Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support system assigned managed identity for embedding dependency #1041

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

abhahn
Copy link
Member

@abhahn abhahn commented Aug 5, 2024

Motivation and Context

Currently we don't support system assigned managed identity for embeddings connections in the webapp. This PR contains an update to add support for it, which is an existing feature in the AOAI OYD API.

Description

  • Updated settings.py to add logic to detect system managed MI settings
  • Updated integration tests for MI use case

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

@abhahn abhahn marked this pull request as ready for review August 6, 2024 17:22
@abhahn abhahn merged commit 6881d7f into main Aug 6, 2024
9 checks passed
@abhahn abhahn deleted the abhahn/embedding-dependency-mi branch August 6, 2024 17:22
"endpoint": self.embedding_endpoint,
"authentication": {
"type": "api_key",
"api_key": self.embedding_key

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "key":

sydneybeckcook pushed a commit to sydneybeckcook/sample-app-aoai-chatGPT-customcookgpt that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants