Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image ingestion QoL improvements #1053

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

vkrd
Copy link
Contributor

@vkrd vkrd commented Aug 13, 2024

Motivation and Context

While running some tests with large documents, I modified the script for some quality-of-life improvements.

Description

  • More descriptive comments
  • Now the image only scales up by 200% if either dimension is smaller than 3 inches
  • Prevent a bug where the image didn't correspond to any text, so it would just insert the image in between every character
  • Limit the number of replacements to 1, so it takes less time

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

@vkrd vkrd self-assigned this Aug 13, 2024
@vkrd vkrd merged commit 787bb05 into main Aug 13, 2024
9 checks passed
@vkrd vkrd deleted the vikramdu/ingest_images_qol_changes branch August 13, 2024 19:39
nikhilnagaraj pushed a commit to Admin-bh-Edge/Edge-Comp-Policies that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants