Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Check for undefined in noContentError incorrectly #768

Merged
merged 2 commits into from
Apr 9, 2024
Merged

[fix] Check for undefined in noContentError incorrectly #768

merged 2 commits into from
Apr 9, 2024

Conversation

iseabock
Copy link
Contributor

@iseabock iseabock commented Apr 8, 2024

Motivation and Context

The previous check for undefined in noContentError was implemented incorrectly.

Description

This fix replaces the noContentError && ... with the optional chaining ?.

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

@iseabock iseabock requested a review from abhahn April 8, 2024 21:23
@tateren tateren mentioned this pull request Apr 9, 2024
Closed
abhahn
abhahn approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@abhahn abhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abhahn abhahn merged commit 62753bb into main Apr 9, 2024
5 checks passed
@abhahn abhahn deleted the NO-TASK-fix-noContentError-check branch April 9, 2024 21:53
rafaelbaum pushed a commit to rafaelbaum/sample that referenced this pull request May 6, 2024
@iseabock @rafaelbaum
[fix] Check for undefined in noContentError incorrectly (microsoft#768)
dd63c04 
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
rafaelbaum pushed a commit to rafaelbaum/sample that referenced this pull request May 10, 2024
@iseabock @rafaelbaum
[fix] Check for undefined in noContentError incorrectly (microsoft#768)
de01337 
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
sudo-init pushed a commit to sudo-init/sample-app-chatGPT that referenced this pull request Sep 20, 2024
@iseabock
[fix] Check for undefined in noContentError incorrectly (microsoft#768)
dc6b780 
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
nikhilnagaraj pushed a commit to Admin-bh-Edge/Edge-Comp-Policies that referenced this pull request Oct 2, 2024
@iseabock
[fix] Check for undefined in noContentError incorrectly (microsoft#768)
13b38d3 
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhahn abhahn abhahn approved these changes

@sarah-widder sarah-widder Awaiting requested review from sarah-widder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iseabock @abhahn