Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for common settings and filter parameter #882

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

abhahn
Copy link
Member

@abhahn abhahn commented May 25, 2024

Motivation and Context

Some of the common search settings are not used in the ARM deployment template used by the Azure OpenAI Studio as originally thought. Moving those settings to each search settings class for now until the template can be updated.

Also fixed an issue with the filter parameter for Azure Search.

Description

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

…void breaking deployment from studio; fix filter parameter
Copy link
Contributor

@iseabock iseabock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abhahn abhahn merged commit cee4fc1 into main May 28, 2024
8 checks passed
@abhahn abhahn deleted the abhahn/settings-update branch May 28, 2024 17:05
ConnieLi-Cook pushed a commit to sydneybeckcook/sample-app-aoai-chatGPT-customcookgpt that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants