Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note on AOAI On Your Data service support for vector search… #887

Closed
wants to merge 0 commits into from

Conversation

MoustafaAMahmoud
Copy link

@MoustafaAMahmoud MoustafaAMahmoud commented May 29, 2024

… in Cosmos DB

Motivation and Context

Description

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

Copy link
Member

@abhahn abhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! I think the location of your change needs to be updated though -- we currently support multiple use cases for CosmosDB, one being as a datasource where vector search is the only option, and the other being for chat history. This change is currently located under the chat history settings description.

I think we may actually need a separate heading for each datasource to describe this correctly. Would you mind writing a separate heading (similar to what we have in the README for Azure Cognitive Search) to describe the use of the Cosmos DB datasource, and move your note to that section?

@MoustafaAMahmoud
Copy link
Author

Thanks a lot for your contribution! I think the location of your change needs to be updated though -- we currently support multiple use cases for CosmosDB, one being as a datasource where vector search is the only option, and the other being for chat history. This change is currently located under the chat history settings description.

I think we may actually need a separate heading for each datasource to describe this correctly. Would you mind writing a separate heading (similar to what we have in the README for Azure Cognitive Search) to describe the use of the Cosmos DB datasource, and move your note to that section?

Got your point. will update this.

@MoustafaAMahmoud
Copy link
Author

I closed this PR, and opened two new ones
#895
#894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants