Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for infra deployment using azure devops #912

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ZahraAsadiMSFT
Copy link

@ZahraAsadiMSFT ZahraAsadiMSFT commented Jun 10, 2024

Motivation and Context

Description

This PR includes several improvements and modifications to the infrastructure deployment setup, aiming to enhance consistency and ease of use.

Changes Made

  1. Incorporated storage-account.bicep into main.bicep:
  • Consolidated the storage account deployment logic into the main Bicep file for better maintainability and clarity.
  1. Modified main.parameters.json to reflect resources addressed in main.bicep:
  • Updated parameters to include appServicePlanName, cosmosAccountName, backendServiceName, resourceGroupName, and storageAccountName.
  1. Standardized principalType across templates:
  • Changed principalType from 'User' to 'ServicePrincipal' in both main.bicep and docprep.bicep.
  • Ensured consistency and avoided potential issues with mixed principal types.
  1. Added Azure Pipelines configuration:
  • Created .azure-pipelines folder.
  • Added azure-pipeline.yml as a template for deploying the infrastructure using Azure DevOps.
  • This pipeline includes steps for installing Bicep, replacing placeholders in parameter files, and deploying the Bicep templates

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants