Hide Stop Generating button when no messages #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-widder
approved these changes
Jun 13, 2024
iseabock
deleted the
NO-TASK-hide-stop-generating-button-when-no-messages
branch
sudo-init
pushed a commit
to sudo-init/sample-app-chatGPT
that referenced
this pull request
Sep 20, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
nikhilnagaraj
pushed a commit
to Admin-bh-Edge/Edge-Comp-Policies
that referenced
this pull request
Oct 2, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previously the "Stop Generating" button would show when there wasn't a message being generated. This was cause by the logic check if cosmodb was loading.
Description
To address this we check if cosmodb
isLoadingand if there are messages in the messages array.Contribution Checklist