[fix] Flashing Contoso logo when custom logo is present #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhahn
reviewed
Jul 10, 2024
iseabock
force-pushed
the
NO-TASK-fix-flashing-logo-when-custom-logo-is-present
branch
from
999f813
to
d2cb933
Compare
abhahn
approved these changes
Jul 11, 2024
iseabock
deleted the
NO-TASK-fix-flashing-logo-when-custom-logo-is-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I noticed when using a custom logo, there was a flash of the Contoso logo before the custom logo was available.
Description
I have a set an isLoading bool so that we can know whether or not the ui settings are set particularly the logo. While is loading is true no logo is shown. When isLoading is false, we check for ui.logo and if true then show that one otherwise show the Contoso logo.
Recording.2024-06-25.141621.mp4
Contribution Checklist