Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable integration tests on the PR gate #967

Merged
merged 9 commits into from
Jun 28, 2024
Merged

Conversation

abhahn
Copy link
Member

@abhahn abhahn commented Jun 28, 2024

Motivation and Context

We currently have no integration tests enabled in our PR workflows. This PR enables previously written integration tests, which have been modified slightly to take secrets from Github secrets.

I also removed a test file which had tests that I didn't think had a lot of value.

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

Copy link
Contributor

@iseabock iseabock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhahn abhahn merged commit 38b7862 into main Jun 28, 2024
1 check passed
@abhahn abhahn deleted the abhahn/enable-integration-tests branch June 28, 2024 22:29
ConnieLi-Cook pushed a commit to sydneybeckcook/sample-app-aoai-chatGPT-customcookgpt that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants