Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add changes to support deployment to Azure Container Apps #994

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abhahn
Copy link
Member

@abhahn abhahn commented Jul 8, 2024

Motivation and Context

Azure Container Apps can enable easy scaling of the webapp in production, and has been specifically asked for by customers previously. This PR makes a few small changes to support easy deployment to ACA from source.

Description

  • Updated the app to check for the presence of X-Ms-Client-Principal as a proxy for identity provider configuration when using Azure Container Apps, which doesn't support the token store in the same way as Azure App Service does.
  • Renamed the dockerfile to allow easy deployment from source (no option to pass in a specific named file when creating the app)

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant