Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Semantic Memory Storage based on Azure Cognitive Search with custom embeddings #1174

Merged

Conversation

dluc
Copy link
Collaborator

@dluc dluc commented May 23, 2023

  • Add new Memory Storage based on Azure Cognitive Search with custom embeddings
  • Delete previous Azure Search memory component based on old semantic search/Lucene

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel samples labels May 23, 2023
@dluc dluc force-pushed the dluc149azurecognitivesearch.3 branch 2 times, most recently from 77b9e6c to 60c95d2 Compare May 23, 2023 02:43
@dluc dluc requested a review from adrianwyatt May 23, 2023 02:45
@dluc dluc changed the title New Azure Search with embedding New Azure Search with embeddings May 23, 2023
@dluc dluc force-pushed the dluc149azurecognitivesearch.3 branch from 60c95d2 to 1fc139a Compare May 23, 2023 05:04
@dluc dluc added the PR: in progress Under development and/or addressing feedback label May 23, 2023
@dluc dluc changed the title New Azure Search with embeddings New Semantic Memory Storage based on Azure Cognitive Search with custom embeddings May 23, 2023
@dmytrostruk
Copy link
Member

Status: waiting for NuGet to be available.

@dluc dluc marked this pull request as ready for review June 12, 2023 23:20
@dluc dluc merged commit 04022a6 into microsoft:feature-azure-search Jun 12, 2023
10 of 14 checks passed
@dluc dluc deleted the dluc149azurecognitivesearch.3 branch June 12, 2023 23:21
/// Semantic Memory implementation using Azure Cognitive Search.
/// For more information about Azure Cognitive Search see https://learn.microsoft.com/azure/search/search-what-is-azure-search
/// </summary>
public class AzureCognitiveSearchMemory : ISemanticTextMemory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just heads up: We stopped removing and renaming classes and their public members, if possible and if they are no longer needed and started marking them as obsolete instead to notify devs. using SK about upcoming changes and giving them time to adapt their code to use a new API.

dluc added a commit that referenced this pull request Jun 14, 2023
…om embeddings (#1174)

* Add new Memory Storage based on Azure Cognitive Search with custom embeddings
* Delete previous Azure Search memory component based on old semantic search/Lucene
dluc added a commit that referenced this pull request Jun 14, 2023
…om embeddings (#1174)

* Add new Memory Storage based on Azure Cognitive Search with custom embeddings
* Delete previous Azure Search memory component based on old semantic search/Lucene
@lemillermicrosoft lemillermicrosoft added this to the Sprint 33 milestone Jun 20, 2023
@matthewbolanos
Copy link
Member

@dluc, will this be resolved by #1174 ?

dluc added a commit that referenced this pull request Jul 6, 2023
…om embeddings (#1174)

* Add new Memory Storage based on Azure Cognitive Search with custom embeddings
* Delete previous Azure Search memory component based on old semantic search/Lucene

Add Azure Cognitive Search vector connector (#1103)

Azure Cognitive Search integration with Python SK
dluc added a commit that referenced this pull request Jul 6, 2023
…om embeddings (#1174)

* Add new Memory Storage based on Azure Cognitive Search with custom embeddings
* Delete previous Azure Search memory component based on old semantic search/Lucene

Add Azure Cognitive Search vector connector (#1103)

* Azure Cognitive Search integration with Python SK
dluc added a commit that referenced this pull request Jul 6, 2023
…om embeddings (#1174)

* Add new Memory Storage based on Azure Cognitive Search with custom embeddings
* Delete previous Azure Search memory component based on old semantic search/Lucene

Add Azure Cognitive Search vector connector (#1103)

* Azure Cognitive Search integration with Python SK
dluc added a commit that referenced this pull request Jul 6, 2023
…om embeddings (#1174)

* Add new Memory Storage based on Azure Cognitive Search with custom embeddings
* Delete previous Azure Search memory component based on old semantic search/Lucene

Add Azure Cognitive Search vector connector (#1103)

* Azure Cognitive Search integration with Python SK
dluc added a commit that referenced this pull request Jul 6, 2023
…om embeddings (#1174)

* Add new Memory Storage based on Azure Cognitive Search with custom embeddings
* Delete previous Azure Search memory component based on old semantic search/Lucene

Add Azure Cognitive Search vector connector (#1103)

* Azure Cognitive Search integration with Python SK
dluc added a commit that referenced this pull request Jul 14, 2023
…om embeddings (#1174)

* Add new Memory Storage based on Azure Cognitive Search with custom embeddings
* Delete previous Azure Search memory component based on old semantic search/Lucene

Add Azure Cognitive Search vector connector (#1103)

* Azure Cognitive Search integration with Python SK
dluc added a commit that referenced this pull request Jul 14, 2023
…om embeddings (#1174)

* Add new Memory Storage based on Azure Cognitive Search with custom embeddings
* Delete previous Azure Search memory component based on old semantic search/Lucene

Add Azure Cognitive Search vector connector (#1103)

* Azure Cognitive Search integration with Python SK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel memory connector .NET Issue or Pull requests regarding .NET code PR: in progress Under development and/or addressing feedback
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants