Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Matrix for the Java SK (Experimental) #1189

Merged
merged 6 commits into from
May 25, 2023
Merged

Feature Matrix for the Java SK (Experimental) #1189

merged 6 commits into from
May 25, 2023

Conversation

brunoborges
Copy link
Member

No description provided.

@shawncal shawncal added docs and tests Improvements or additions to documentation java Issue or PR regarding Java code labels May 23, 2023
Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment but otherwise LGTM

FEATURE_MATRIX.md Outdated Show resolved Hide resolved
@markwallace-microsoft markwallace-microsoft added the PR: ready for review All feedback addressed, ready for reviews label May 24, 2023
johnoliver
johnoliver previously approved these changes May 24, 2023
@lemillermicrosoft
Copy link
Member

Shouldn't this target the experimental-java branch until it lands in main?

@markwallace-microsoft
Copy link
Member

Shouldn't this target the experimental-java branch until it lands in main?

@lemillermicrosoft two things:

  1. We want this in main to raise awareness that we have an experimental Java implementation and the progress we are making
  2. Changes to experimental-java are all in the java folder. Changes outside of the Java folder should go to main so we avoid merge conflicts when we automate updating the experimental-java branch.

Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brunoborges see my comment for a suggestion on a follow up PR

@markwallace-microsoft markwallace-microsoft added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: ready for review All feedback addressed, ready for reviews labels May 24, 2023
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) May 25, 2023 21:07
@lemillermicrosoft lemillermicrosoft merged commit 1ee6461 into microsoft:main May 25, 2023
15 checks passed
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and tests Improvements or additions to documentation java Issue or PR regarding Java code PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants