-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: #6499 Mistral AI Function Calling #8016
Merged
moonbox3
merged 38 commits into
microsoft:main
from
nmoeller:issue-6499-Mistral-Ai-Function-Calling
Sep 11, 2024
Merged
Python: #6499 Mistral AI Function Calling #8016
moonbox3
merged 38 commits into
microsoft:main
from
nmoeller:issue-6499-Mistral-Ai-Function-Calling
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Aug 9, 2024
github-actions
bot
changed the title
#6499 Mistral AI Function Calling
Python: #6499 Mistral AI Function Calling
Aug 9, 2024
Should we already try to get the feature in the main branch or does it make sense to wait till #8020 is finished ? Since i was staying close to the OpenAi connector i will have the same behavior. |
Python Test Coverage Report
Python Unit Test Overview
|
TaoChenOSU
reviewed
Aug 15, 2024
...l/connectors/ai/mistral_ai/prompt_execution_settings/mistral_ai_prompt_execution_settings.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
reviewed
Aug 15, 2024
python/semantic_kernel/connectors/ai/mistral_ai/services/mistral_ai_chat_completion.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
reviewed
Aug 15, 2024
python/semantic_kernel/connectors/ai/mistral_ai/services/mistral_ai_chat_completion.py
Outdated
Show resolved
Hide resolved
moonbox3
reviewed
Aug 15, 2024
python/semantic_kernel/connectors/ai/mistral_ai/services/mistral_ai_chat_completion.py
Outdated
Show resolved
Hide resolved
…ub.com/nmoeller/semantic-kernel into issue-6499-Mistral-Ai-Function-Calling
moonbox3
reviewed
Aug 21, 2024
python/semantic_kernel/connectors/ai/mistral_ai/services/mistral_ai_chat_completion.py
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2024
moonbox3
approved these changes
Sep 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> 1. Why is this changed required ? To enable Mistral Models with Semantic Kernel, there was the issue #6499 in the Backlog to add a MistralAI Connector 2. What problem does it solve ? It solves the problem, that semantic kernel is not yet integrated with MistralAI 3. What scenario does it contribute to? The scenario is to use different connector than HF,OpenAI or AzureOpenAI. When User's want to use Mistral they can easliy integrate it now 4. If it fixes an open issue, please link to the issue here. #6499 ### Description The changes made are designed by the open_ai connector, i tried to stay as close as possible to the structure. For the integration i installed the mistral python package in the repository. After Integrating ChatCompletion and Embeddings now i would like to bring in FunctionCalling What is integrated yet : - [X] MistralAI FunctionCalling - [X] MistralAI FunctionCalling Streaming - [x] Extended Testing including Unit Testing - [x] Integration Tests with FunctionCalling ### Some Notes - Integration Tests are skipped when the environment variables are not to not break the current Integration Tests ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Eduard van Valkenburg <[email protected]> Co-authored-by: Tao Chen <[email protected]> Co-authored-by: Evan Mattson <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 11, 2024
moonbox3
approved these changes
Sep 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 11, 2024
…ub.com/nmoeller/semantic-kernel into issue-6499-Mistral-Ai-Function-Calling
moonbox3
approved these changes
Sep 11, 2024
auto-merge was automatically disabled
September 11, 2024 17:29
Head branch was pushed to by a user without write access
moonbox3
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To enable Mistral Models with Semantic Kernel, there was the issue Python: Add Mistral AI Connector #6499 in the Backlog to add a MistralAI Connector
It solves the problem, that semantic kernel is not yet integrated with MistralAI
The scenario is to use different connector than HF,OpenAI or AzureOpenAI. When User's want to use Mistral they can easliy integrate it now
Python: Add Mistral AI Connector #6499
Description
The changes made are designed by the open_ai connector, i tried to stay as close as possible to the structure.
For the integration i installed the mistral python package in the repository.
After Integrating ChatCompletion and Embeddings now i would like to bring in FunctionCalling
What is integrated yet :
Some Notes
Contribution Checklist