-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Add PostgresVectorStore Memory connector. #9324
.Net: Add PostgresVectorStore Memory connector. #9324
Conversation
Work in progress, some methods are not implemented yet.
dotnet/src/Connectors/Connectors.Memory.Postgres/PostgresConstants.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Postgres/PostgresVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Postgres/PostgresVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
…ctor-store-dotnet
…ctor-store-dotnet
@westey-m most recent comments addressed, thanks! |
…ctor-store-dotnet
Thanks for the work on this feature. We are currently using the legacy Memory Store but that was recently marked as legacy and the connector for Postgres is currently marked as in-development, but as i see here it is probably at-least ready for alpha testing. Is it available for testing already in any channel or is any ETA available for it? Again, sorry if that is not the right place to ask. Thanks! |
@Hanake0, no problem. It's been a bit busy lately with various deadlines, but I was meaning to get back to this again this week. With the start of the holiday period, giving an ETA will be difficult, but we'll certainly be progressing it as a priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small comments, but in general looks good to me! Thanks for your contribution!
dotnet/samples/Concepts/Memory/VectorStoreFixtures/VectorStorePostgresContainerFixture.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/Concepts/Memory/VectorStore_VectorSearch_MultiStore_Postgres.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Postgres/IPostgresDbClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Postgres/PostgresDbClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Postgres/PostgresGenericDataModelMapper.cs
Show resolved
Hide resolved
@dmytrostruk @westey-m Thanks for getting this over the finish line! I was out on parental leave but am back and can take on any follow up work. Feel free to tag me in any related issues etc. |
This PR adds a PostgresVectorStore and related classes to Microsoft.SemanticKernel.Connectors.Postgres.
Motivation and Context
As part of the move to having memory connectors implement the new Microsoft.Extensions.VectorData.IVectorStore architecture (see https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0050-updated-vector-store-design.md), each memory connector needs to be updated with the new architecture. This PR tackles updating the existing Microsoft.SemanticKernel.Connectors.Postgres package to include this implementation. This will supercede the PostgresMemoryStore implementation.
Some high level comments about design:
Contribution Checklist