-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: OpenAPI plugin updates to promote plugin to preview #9670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Nov 12, 2024
TaoChenOSU
approved these changes
Nov 12, 2024
python/semantic_kernel/connectors/openapi_plugin/openapi_manager.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/openapi_plugin/models/rest_api_oauth_flow.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/openapi_plugin/models/rest_api_oauth_flows.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/openapi_plugin/models/rest_api_security_requirement.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/openapi_plugin/openapi_manager.py
Outdated
Show resolved
Hide resolved
…ion skip predicate. Allow for customer spec parsing.
moonbox3
changed the title
Python: OpenAPI updates to support multiple operation servers & security config
Python: OpenAPI plugin updates to promote plugin to preview
Nov 15, 2024
TaoChenOSU
approved these changes
Nov 15, 2024
python/semantic_kernel/connectors/openai_plugin/openai_function_execution_parameters.py
Show resolved
Hide resolved
eavanvalkenburg
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of classes that I think can be easier with a pydantic or dataclass, but not blocking
python/semantic_kernel/connectors/openapi_plugin/models/rest_api_expected_response.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/openapi_plugin/models/rest_api_parameter.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/openapi_plugin/models/rest_api_payload.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/openapi_plugin/models/rest_api_payload_property.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/openapi_plugin/models/rest_api_security_scheme.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/openapi_plugin/operation_selection_predicate_context.py
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 20, 2024
alliscode
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We currently handle OpenAPI plugins via the kernel, but in a pretty simple way. The changes in this PR are allowing one to define multiple server paths for an operation as well as configure security on the operations either at the operation level or at the "global" spec level (these are included as metadata in the kernel function parameter
additional_parameters
dict).The OpenAPI plugin is graduating from an experimental state to a preview state. This, in turn, removes the
experimental
tag from some public facing methods. In the near future, allexperimental
tags will be removed once we're confident there are no other underlying changes required.Closes #9719
Description
Adds support for OpenAPI plugin:
excluded_operations
on the execution settings were never checked during REST API operation buildingOpenAI plugin
code as it was deprecated by OpenAI and we never handled it in SK Python.operation
portion of the name.Contribution Checklist