WIP: Refactor representation of thread local state. #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjp41
force-pushed
the
thread_local_refactor
branch
2 times, most recently
from
318a880 to
0614a01
Compare
mjp41
changed the title
mjp41
force-pushed
the
thread_local_refactor
branch
3 times, most recently
from
80d24e0 to
0fd6768
Compare
nwf
reviewed
Feb 21, 2025
src/snmalloc/global/globalalloc.h
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| namespace snmalloc | |||
| { | |||
| template<SNMALLOC_CONCEPT(IsConfig) Config> | |||
| template<SNMALLOC_CONCEPT(IsConfig) Config = Config> | |||
There was a problem hiding this comment.
- I'm a little surprised these aren't triggering shadowing warnings?
- Are these functions ever invoked with non-default
Configs? If not, maybe convert the template parameter and concept annotation to a suitablestatic_assertrequires?
nwf
reviewed
Feb 21, 2025
CMakeLists.txt
Outdated
|
|
||
| foreach(FLAVOUR ${FLAVOURS}) | ||
| if (${FLAVOUR} STREQUAL "malloc") | ||
| set(DEFINES SNMALLOC_PASS_THROUGH) | ||
| endif() |
nwf
reviewed
Feb 21, 2025
|
Only found time to make it into "Restrict ThreadAlloc usage to globalalloc", but so far so great. Thanks for nwfifying the commit stack. :D |
mjp41
force-pushed
the
thread_local_refactor
branch
5 times, most recently
from
41392d1 to
654bcfd
Compare
nwf
reviewed
Feb 21, 2025
src/snmalloc/mem/localalloc.h
Outdated
| return self->alloc_not_small<zero_mem, CheckInitDefault>(size); | ||
| }, | ||
| size, | ||
| this); |
There was a problem hiding this comment.
It's a bit of a pity that something so formulaic can't, AFAIK, be templated away.
The check init code was tightly integrated into LocalAllocator. This commit pull that code out into ThreadAlloc, and passes a template parameter into the remaining LocalAllocator to perform the relevant TLS manipulations. This removes some of the awkward layering around register_clean_up.
Fully disable lotsofthreads test Need to investigate if the test is unreliable, or we have actually regressed perf. A quick mimalloc-bench didn't show any regressions.
This introduces one additional branch on when processing a batch of messages, but it is likely to only be hit when a lot of messages are processed.
mjp41
force-pushed
the
thread_local_refactor
branch
from
654bcfd to
fdab65d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #750