keeping the target db to what ever client is sending (#443)

microsoft · Aug 25, 2017 · 5ab995d · 5ab995d
1 parent eb61423
commit 5ab995d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/...Microsoft.SqlTools.ServiceLayer/DisasterRecovery/RestoreOperation/RestoreOptionFactory.cs b/...Microsoft.SqlTools.ServiceLayer/DisasterRecovery/RestoreOperation/RestoreOptionFactory.cs
@@ -537,15 +537,9 @@ private RestoreOptionFactory()
                    },
                    ValidateFunction = (IRestoreDatabaseTaskDataObject restoreDataObject, object currentValue, object defaultValue) =>
                    {
-                       string errorMessage = string.Empty;
-                       if (currentValue!= null && DatabaseUtils.IsSystemDatabaseConnection(currentValue.ToString()))
-                       {
-                           errorMessage = "Cannot restore to system database";
-                       }
                        return new OptionValidationResult()
                        {
-                           IsReadOnly = !restoreDataObject.CanChangeTargetDatabase,
-                           ErrorMessage = errorMessage
+                           IsReadOnly = false
                        };
                    },
                    SetValueFunction = (IRestoreDatabaseTaskDataObject restoreDataObject, object value) =>

diff --git a/test/Microsoft.SqlTools.ServiceLayer.UnitTests/DisasterRecovery/RestoreOptionsHelperTests.cs b/test/Microsoft.SqlTools.ServiceLayer.UnitTests/DisasterRecovery/RestoreOptionsHelperTests.cs
@@ -246,7 +246,7 @@ public void SourceDatabaseNameShouldStayTheSameIfValid()
         }
 
         [Fact]
-        public void TargetDatabaseNameShouldSetToDefaultIfNotValid()
+        public void TargetDatabaseNameShouldBeWhatIsRequested()
         {
             RestoreParams restoreParams = CreateOptionsTestData();
             string defaultDbName = "default";
@@ -260,12 +260,12 @@ public void TargetDatabaseNameShouldSetToDefaultIfNotValid()
             RestoreOptionFactory.Instance.SetAndValidate(RestoreOptionsHelper.TargetDatabaseName, restoreDatabaseTaskDataObject);
 
             string actual = restoreDatabaseTaskDataObject.TargetDatabaseName;
-            string expected = defaultDbName;
+            string expected = currentDbName;
             Assert.Equal(actual, expected);
         }
 
         [Fact]
-        public void TargetDatabaseNameShouldStayTheSameIfValid()
+        public void TargetDatabaseNameShouldBeWhatIsRequested2()
         {
             RestoreParams restoreParams = CreateOptionsTestData();
             string defaultDbName = "default";