Skip to content

Remove dropped ledger columns from Edit Data columns #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nofield merged 3 commits into from
Sep 19, 2022
Merged

Remove dropped ledger columns from Edit Data columns #1691

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21470b0
remove dropped ledger columns from Edit Data columns
nofield Sep 15, 2022
b6e5707
moving dropped ledger filtering to column retrieval from SMO
nofield Sep 19, 2022
b352be0
fix clear and initialize placement and retrieve DefaultConstraintName
nofield Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Microsoft.SqlTools.ServiceLayer/EditData/SmoEditMetadataFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ public EditTableMetadata GetObjectMetadata(DbConnection connection, string[] obj
throw new ArgumentOutOfRangeException(nameof(objectNamedParts), SR.EditDataObjectNotFound);
}

// Filter out dropped ledger columns from the list of columns to be returned
// and grab the specific column properties checked below
smoResult.Columns.ClearAndInitialize("[(@IsDroppedLedgerColumn=0)]", new [] { nameof(Column.DataType), nameof(Column.DefaultConstraintName) });

// Generate the edit column metadata
List<EditColumnMetadata> editColumns = new List<EditColumnMetadata>();
for (int i = 0; i < smoResult.Columns.Count; i++)
Expand All @@ -103,7 +107,7 @@ public EditTableMetadata GetObjectMetadata(DbConnection connection, string[] obj
try
{
// The default value may be escaped
defaultValue = smoColumn.DefaultConstraint == null
defaultValue = string.IsNullOrEmpty(smoColumn.DefaultConstraintName)
? null
: FromSqlScript.UnwrapLiteral(smoColumn.DefaultConstraint.Text);
}
Expand Down