-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves "save as Excel" functionality #2266
Conversation
ckaczor
commented
Oct 10, 2023
- Adds option to bold the header row
- Adds option to freeze the header row
- Adds option to enable auto filtering on the header row
- Adds option to automatically size columns based on content
- Adds option to bold the header row - Adds option to freeze the header row - Adds option to enable auto filtering on the header row - Adds option to automatically size columns based on content
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
@kisantia Something for you to look at for consideration. |
@cheenamalhotra can you please take a look and consider this? @ckaczor can you please add screenshots of how this looks and how the options will be exposed in ADS? |
The corresponding ADS code changes are here: https://github.com/ckaczor/azuredatastudio/tree/save-as-excel This is how the options look in the UI: I had wanted to have the settings layout and behavior more dependent on the "include headers" checkbox but I couldn't find any way to do that with the current ADS code. |
I don't have a Mac system for testing but I confirmed that SkiaSharp supports Mac systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ckaczor
Thanks for contributing this work!
Please proceed to open peer PR in ADS repo with the changes in https://github.com/ckaczor/azuredatastudio/tree/save-as-excel branch and address minor feedback. Looking forward to getting the new features out in next ADS release!
cc @erinstellato-ms for visibility.
...rosoft.SqlTools.ServiceLayer/QueryExecution/DataStorage/SaveAsExcelFileStreamWriterHelper.cs
Outdated
Show resolved
Hide resolved
....ServiceLayer.UnitTests/QueryExecution/DataStorage/SaveAsExcelFileStreamWriterHelperTests.cs
Show resolved
Hide resolved
....ServiceLayer.UnitTests/QueryExecution/DataStorage/SaveAsExcelFileStreamWriterHelperTests.cs
Show resolved
Hide resolved
...rosoft.SqlTools.ServiceLayer/QueryExecution/DataStorage/SaveAsExcelFileStreamWriterHelper.cs
Show resolved
Hide resolved
/azp run |
No pipelines are associated with this pull request. |
- Fail tests if expected exception did not get thrown - Add documention of columnCount parameter for ExcelSheet constructor - Add element comments to new (and existing) WriteEndElement calls