Fixing filter ordering #2403
Merged
Fixing filter ordering #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
caohai
reviewed
Oct 9, 2024
caohai
reviewed
Oct 9, 2024
src/Microsoft.SqlTools.Migration/Microsoft.SqlTools.Migration.csproj
Outdated
Show resolved
Hide resolved
caohai
approved these changes
Oct 9, 2024
aasimkhan30
commented
Oct 10, 2024
There was a problem hiding this comment.
Autogen file please ignore.
|
Are all the package ref updates part of the reordering changes, or unrelated? |
Benjin
approved these changes
Oct 10, 2024
|
@Benjin created a separate PR for those. Reverting package updates from this PR |
aasimkhan30
force-pushed
the
aasim/feat/18157
branch
from
1d2b5bf to
eae45bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes microsoft/vscode-mssql#18157