Skip to content

Commit

Permalink
[repo] docs: fix typo (#2113)
Browse files Browse the repository at this point in the history
## Details
#minor
Just a typo correction.

(see: https://prowritingaid.com/comming-or-coming)

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes
  • Loading branch information
qb-dornak authored Oct 14, 2024
1 parent eaf1a52 commit e5ece1e
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion dotnet/samples/04.ai.a.teamsChefBot/files/c#-migration.txt
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ app.OnActivity(ActivityTypes.Message, async (ITurnContext turnContext, TurnState
});
```

> The `OnActivity` method allows you to register a possible route for the incomming activity. For each method in the `ActivityHandler` or `TeamsActivityHandler` class, there is an equivalent route registration method.
> The `OnActivity` method allows you to register a possible route for the incoming activity. For each method in the `ActivityHandler` or `TeamsActivityHandler` class, there is an equivalent route registration method.

If your bot derives from `ActivityHandler` or the `TeamsActivityHandler` refer to the following table to see which method maps to which `Application` route registration method.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ app.OnActivity(ActivityTypes.Message, async (ITurnContext turnContext, TurnState
});
```

> The `OnActivity` method allows you to register a possible route for the incomming activity. For each method in the `ActivityHandler` or `TeamsActivityHandler` class, there is an equivalent route registration method.
> The `OnActivity` method allows you to register a possible route for the incoming activity. For each method in the `ActivityHandler` or `TeamsActivityHandler` class, there is an equivalent route registration method.

If your bot derives from `ActivityHandler` or the `TeamsActivityHandler` refer to the following table to see which method maps to which `Application` route registration method.

Expand Down
2 changes: 1 addition & 1 deletion getting-started/CONCEPTS/USER-AUTH.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ auth=AuthOptions(
settings={})
```

The `autoSignIn` property takes a callback that triggers the sign in flow if it returns true. It depends on the turn context from which the incomming activity details can be extracted. In the above example, the library will not attempt to sign the user in if the incoming activity `commandId` is _"signOutCommand"_.
The `autoSignIn` property takes a callback that triggers the sign in flow if it returns true. It depends on the turn context from which the incoming activity details can be extracted. In the above example, the library will not attempt to sign the user in if the incoming activity `commandId` is _"signOutCommand"_.

This is useful if the user should be signed in by default before attempting to interacting with the bot in general.

Expand Down
2 changes: 1 addition & 1 deletion getting-started/MIGRATION/02.DOTNET.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ app.OnActivity(ActivityTypes.Message, async (ITurnContext turnContext, TurnState
});
```

> The `OnActivity` method allows you to register a possible route for the incomming activity. For each method in the `ActivityHandler` or `TeamsActivityHandler` class, there is an equivalent route registration method.
> The `OnActivity` method allows you to register a possible route for the incoming activity. For each method in the `ActivityHandler` or `TeamsActivityHandler` class, there is an equivalent route registration method.
If your bot derives from `ActivityHandler` or the `TeamsActivityHandler` refer to the following table to see which method maps to which `Application` route registration method.

Expand Down
20 changes: 10 additions & 10 deletions js/packages/teams-ai/src/AdaptiveCards.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('AdaptiveCards', () => {
assert((await selector(context)) == true);
});

it('incomming activity is invalid', async () => {
it('incoming activity is invalid', async () => {
const activity = {
type: 'NotInvoke'
};
Expand Down Expand Up @@ -133,7 +133,7 @@ describe('AdaptiveCards', () => {
assert(typeof handler === 'function');
});

it('should throw error if incomming activity is not valid', async () => {
it('should throw error if incoming activity is not valid', async () => {
adaptiveCards.actionExecute(testVerb, testHandler);

const activity = {
Expand Down Expand Up @@ -566,7 +566,7 @@ describe('AdaptiveCards', () => {
adaptiveCards.actionSubmit(verbRegex, testHandler);
});

it('incomming activity is valid action submit type and should match regex', async () => {
it('incoming activity is valid action submit type and should match regex', async () => {
// a valid action submit type is a message activity with a value property.
const activity = {
type: 'message',
Expand All @@ -581,7 +581,7 @@ describe('AdaptiveCards', () => {
assert((await selector(context)) == true);
});

it('incomming activity is valid action submit type and should not match regex ', async () => {
it('incoming activity is valid action submit type and should not match regex ', async () => {
// a valid action submit type is a message activity with a value property.
const activity = {
type: 'message',
Expand All @@ -596,7 +596,7 @@ describe('AdaptiveCards', () => {
assert((await selector(context)) == false);
});

it('incomming activity is invalid', async () => {
it('incoming activity is invalid', async () => {
const activity = {
type: 'notActionSubmit'
};
Expand Down Expand Up @@ -663,7 +663,7 @@ describe('AdaptiveCards', () => {
assert(typeof handler === 'function');
});

it('should throw error if incomming activity is not valid', async () => {
it('should throw error if incoming activity is not valid', async () => {
adaptiveCards.actionSubmit(testVerb, testHandler);

const activity = {
Expand Down Expand Up @@ -738,7 +738,7 @@ describe('AdaptiveCards', () => {
adaptiveCards.search(datasetRegex, testHandler);
});

it('incomming activity is valid application/search type and should match regex', async () => {
it('incoming activity is valid application/search type and should match regex', async () => {
const activity = {
type: 'invoke',
name: 'application/search',
Expand All @@ -752,7 +752,7 @@ describe('AdaptiveCards', () => {
assert((await selector(context)) == true);
});

it('incomming activity is valid application/search type and should not match regex ', async () => {
it('incoming activity is valid application/search type and should not match regex ', async () => {
const activity = {
type: 'invoke',
name: 'application/search',
Expand All @@ -766,7 +766,7 @@ describe('AdaptiveCards', () => {
assert((await selector(context)) == false);
});

it('incomming activity is invalid', async () => {
it('incoming activity is invalid', async () => {
const activity = {
type: 'NotInvoke'
};
Expand Down Expand Up @@ -829,7 +829,7 @@ describe('AdaptiveCards', () => {
assert(typeof handler === 'function');
});

it('should throw error if incomming activity is not valid', async () => {
it('should throw error if incoming activity is not valid', async () => {
adaptiveCards.search(testDataset, testHandler);

const activity = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ describe('Authentication', () => {
assert.rejects(
async () => await auth.signInUser(context, state),
new AuthError(
'Incomming activity is not a valid activity to initiate authentication flow.',
'Incoming activity is not a valid activity to initiate authentication flow.',
'invalidActivity'
)
);
Expand Down
2 changes: 1 addition & 1 deletion js/packages/teams-ai/src/authentication/Authentication.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export class Authentication<TState extends TurnState> {
}

throw new AuthError(
'Incomming activity is not a valid activity to initiate authentication flow.',
'Incoming activity is not a valid activity to initiate authentication flow.',
'invalidActivity'
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ describe('OAuthBotAuthentication', () => {
});

describe('authenticate()', () => {
it('should save incomming message if not signed in yet', async () => {
it('should save incoming message if not signed in yet', async () => {
const botAuth = new OAuthBotAuthentication(app, settings, settingName);

const runDialogStub = sinon.stub(botAuth, 'runDialog');
Expand Down

0 comments on commit e5ece1e

Please sign in to comment.