Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] chore: UserAccessToken, DataSourceSection, FunctionCallMessage, FunctionResponseMessage Unit Tests #1145

Merged
merged 2 commits into from
Jan 10, 2024
Merged

[JS] chore: UserAccessToken, DataSourceSection, FunctionCallMessage, FunctionResponseMessage Unit Tests #1145

merged 2 commits into from
Jan 10, 2024

Conversation

lilyydu
Copy link
Contributor

@lilyydu lilyydu commented Jan 9, 2024

Linked issues

closes: #54

Details

  • Added error test cases for UserAccessToken
  • Added tests for DataSourceSection, FunctionCallMessage, FunctionResponseMessage

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams

  • New and existing unit tests pass locally with my changes

corinagum

This comment was marked as outdated.

Sign in to view

@corinagum corinagum dismissed their stale review January 10, 2024 00:04

Comments are incorrect

corinagum
corinagum approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad -- looks great, thank you!

@corinagum corinagum merged commit 8258ca0 into main Jan 10, 2024
15 checks passed
@corinagum corinagum deleted the lilyydu/promptsectionbase-and-token-tests branch January 10, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@aacebo aacebo Awaiting requested review from aacebo aacebo is a code owner

@singhk97 singhk97 Awaiting requested review from singhk97 singhk97 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JS] Unit tests
2 participants
@lilyydu @corinagum