Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] feat: O1 model support #2111

Merged
merged 9 commits into from
Oct 17, 2024
Merged

[C#] feat: O1 model support #2111

merged 9 commits into from
Oct 17, 2024

Conversation

singhk97
Copy link
Collaborator

@singhk97 singhk97 commented Oct 13, 2024

Linked issues

closes: #2103

Details

Added support for o1-preview and o1-mini models.

  • Bumped OpenAI and Azure.AI.OpenAI to 2.1.0-beta.1.
  • Tested o1 support with light bot sample with monologue augmentation.
  • Updated teamsChefBot-streaming to use deployed Microsoft.Teams.AI nuget package.
  • Fixed LayoutSection bug with incorrect ordering of sections.

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to merge this into the C# dev branch instead of main?

@singhk97 singhk97 changed the base branch from main to dotnet-dev October 15, 2024 16:30
@singhk97
Copy link
Collaborator Author

Do we want to merge this into the C# dev branch instead of main?

Good catch - updated.

@singhk97
Copy link
Collaborator Author

I have tested the streaming samples - and it works.

Copy link
Collaborator

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@singhk97 singhk97 merged commit d4ac6c4 into dotnet-dev Oct 17, 2024
9 checks passed
@singhk97 singhk97 deleted the kavin/c#-o1 branch October 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] C# o1 preview parity
3 participants