[JS] chore: remove @azure/openai-assistants dependency from AssistantsPlanner.ts #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilyydu
reviewed
Oct 31, 2024
| if (!run || this.isRunCompleted(run)) { | ||
| return; | ||
| const latestRun = runs.data[0]; | ||
| if (this.isRunCompleted(latestRun)) { |
There was a problem hiding this comment.
should we still have a !latestRun check
| // Update state and wait for the run to complete | ||
| this.updateAssistantsState(state, { thread_id, run_id: run.id, last_message_id: message.id ?? null }); | ||
| const results = await this.waitForRun(thread_id, run.id, true); | ||
| this.updateAssistantsState(state, { thread_id: threadId, run_id: run.id, last_message_id: message.id }); |
There was a problem hiding this comment.
same suggestion about null check on message.id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
#minor #1585
Details
Attestation Checklist
My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes
Additional information