Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE [JS] feat: custom feedback form + citation changes #2182

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

aacebo
Copy link
Collaborator

@aacebo aacebo commented Nov 12, 2024

Linked issues

closes: #2167

Details

update types/handlers for new custom feedback loop and citations changes for ignite.

@aacebo aacebo marked this pull request as ready for review November 13, 2024 16:06
corinagum
corinagum previously approved these changes Nov 18, 2024
Copy link
Collaborator

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Alex!

Copy link

@jk-msft jk-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

corinagum
corinagum previously approved these changes Nov 25, 2024
@corinagum corinagum changed the title [JS] feat: custom feedback form + citation changes DO NOT MERGE [JS] feat: custom feedback form + citation changes Dec 3, 2024
@aacebo aacebo merged commit eb63a75 into main Dec 5, 2024
10 of 11 checks passed
@aacebo aacebo deleted the aacebo/js/custom-feedback-form branch December 5, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants