-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] feat: streaming support for Tools Augmentation #2195
Merged
Merged
+97
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stevenic
requested review from
aacebo,
corinagum,
lilyydu,
singhk97 and
rajan-chari
as code owners
November 21, 2024 01:12
Hey Steve, I filed a sub issue and linked it in your summary :) |
corinagum
reviewed
Nov 21, 2024
lilyydu
reviewed
Nov 26, 2024
lilyydu
reviewed
Nov 26, 2024
lilyydu
reviewed
Dec 2, 2024
lilyydu
reviewed
Dec 2, 2024
lilyydu
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM, thanks Steve! do you mind adding tests (as per Corina's request also)
I added a note that there isn't a way to test it... the stub class you're using doesn't support stubbing out Server Sent Events. |
corinagum
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
closes: #2197
Details
This update adds support for properly calling tools with streaming support. It doesn't solve for the other augmentation types as that's much more challenging.
Change details
The challenge with streaming + tool use is that we need to make multiple calls to the model and we can only have a single stream open to the teams client. To address this we end up leveraging the fact that the Streamer is being cached to temp state and we let the tool call happen as it normally world. To the tool call its as if its a non-streaming message but the Streamer object is kept in memory (temp state) waiting for the tool call to complete. We a new request is made to the ActionPlanner, the created LLMClient will see that it's already created a Streamer and attach to that instance.
There was a bit of book keeping that needed to be done but it's a straightforward change.
code snippets:
screenshots:
Attestation Checklist
[x ] My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes
Additional information