Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] bump: Updating Feedback buttons to the sample #2245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jegadeesh-MSFT
Copy link

@Jegadeesh-MSFT Jegadeesh-MSFT commented Dec 24, 2024

Linked update

This PR adds feedback button functionality to the sample.
#minor : https://review.learn.microsoft.com/en-us/microsoftteams/platform/bots/how-to/bot-messages-ai-generated-content?branch=pr-en-us-11185&tabs=before%2Cbotmessage#feedback-buttons

Details

Provide a list of your changes here. If you are fixing a bug, please provide steps to reproduce the bug.

  1. Added feedback functionality for users.
  2. Introduced two new options for feedback:
    Default Feedback: Users can type "default feedback" to provide predefined feedback.
    Custom Feedback: Users can type "custom feedback" to provide personalized feedback.
  3. Updated the bot's welcome message to inform users about these feedback options.

Change details

Describe your changes, with screenshots and code snippets as appropriate

code snippets:

screenshots:

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

@Jegadeesh-MSFT Jegadeesh-MSFT changed the title Updating Feedback buttons to the sample [JS] refactor: Updating Feedback buttons to the sample Dec 24, 2024
@Jegadeesh-MSFT Jegadeesh-MSFT changed the title [JS] refactor: Updating Feedback buttons to the sample [JS] bump: Updating Feedback buttons to the sample Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant