Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] feat: ApplicationBuilder Implementation #756

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

lilyydu
Copy link
Contributor

@lilyydu lilyydu commented Oct 30, 2023

Linked issues

closes: #710
associated: #615

associated JS changes (already merged): #651

Details

  • Added the ApplicationBuilder class, and associated tests
  • Added in missing tests for Application construction
  • Updated docs
  • Updated 2 samples (04.ai.b.messageExtensions.AI-ME and 04.e.twentyQuestions) to use builder pattern

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

…pplication builder, updated 2 samples and docs
@lilyydu lilyydu added enhancement New feature or request dotnet Change/fix applies to dotnet. If all three, use the 'JS & dotnet & Python' label labels Oct 30, 2023
@lilyydu lilyydu requested review from singhk97, swatDong, kuojianlu and a team as code owners October 30, 2023 20:28
@lilyydu lilyydu merged commit a0319df into dotnetfluent Oct 30, 2023
8 checks passed
@lilyydu lilyydu deleted the lilyydu/applicationbuilderfluent branch October 30, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Change/fix applies to dotnet. If all three, use the 'JS & dotnet & Python' label enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants