Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] feat: handles message update/delete events #763

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

kuojianlu
Copy link
Contributor

@kuojianlu kuojianlu commented Oct 31, 2023

Linked issues

closes: #761

Details

Change details

  • messageUpdate - editMessage
  • messageUpdate - undeleteMessage
  • messageDelete - softDeleteMessage

Reference: https://github.com/microsoft/botbuilder-dotnet/blob/main/libraries/Microsoft.Bot.Builder/Teams/TeamsActivityHandler.cs#L903

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

- messageUpdate - editMessage
- messageUpdate - undeleteMessage
- messageDelete - softDeleteMessage
@swatDong
Copy link
Contributor

swatDong commented Nov 1, 2023

The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.NotImplementedException: The method or operation is not implemented.
at Microsoft.TeamsAI.Tests.TestUtils.NotImplementedAdapter.SendActivitiesAsync(ITurnContext turnContext, Activity[] activities, CancellationToken cancellationToken) in D:\a\teams-ai\teams-ai\dotnet\packages\Microsoft.TeamsAI\Microsoft.TeamsAI.Tests\TestUtils\NotImplementedAdapter.cs:line 15
at Microsoft.Bot.Builder.TurnContext.<>c__DisplayClass31_0.<g__SendActivitiesThroughAdapter|1>d.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.Bot.Builder.TurnContext.SendActivityAsync(IActivity activity, CancellationToken cancellationToken)
at Microsoft.TeamsAI.TypingTimer.SendTypingActivity(Object state) in D:\a\teams-ai\teams-ai\dotnet\packages\Microsoft.TeamsAI\Microsoft.TeamsAI\TypingTimer.cs:line 103

UT failed? It seems certain UT does not disable typing timer...
May not be related to this PR's change

@kuojianlu
Copy link
Contributor Author

The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.NotImplementedException: The method or operation is not implemented.
at Microsoft.TeamsAI.Tests.TestUtils.NotImplementedAdapter.SendActivitiesAsync(ITurnContext turnContext, Activity[] activities, CancellationToken cancellationToken) in D:\a\teams-ai\teams-ai\dotnet\packages\Microsoft.TeamsAI\Microsoft.TeamsAI.Tests\TestUtils\NotImplementedAdapter.cs:line 15
at Microsoft.Bot.Builder.TurnContext.<>c__DisplayClass31_0.<g__SendActivitiesThroughAdapter|1>d.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.Bot.Builder.TurnContext.SendActivityAsync(IActivity activity, CancellationToken cancellationToken)
at Microsoft.TeamsAI.TypingTimer.SendTypingActivity(Object state) in D:\a\teams-ai\teams-ai\dotnet\packages\Microsoft.TeamsAI\Microsoft.TeamsAI\TypingTimer.cs:line 103

UT failed? It seems certain UT does not disable typing timer... May not be related to this PR's change

Good notice. Fixed it.

@kuojianlu kuojianlu merged commit a0557e4 into dotnetfluent Nov 1, 2023
7 checks passed
@kuojianlu kuojianlu deleted the kuojianlu/message-updates-fluent branch November 1, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants