Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] feat: add meeting handlers #771

Merged
merged 2 commits into from
Nov 6, 2023
Merged

[C#] feat: add meeting handlers #771

merged 2 commits into from
Nov 6, 2023

Conversation

swatDong
Copy link
Contributor

@swatDong swatDong commented Nov 3, 2023

Linked issues

closes: #696

Details

Add handlers for meeting events

Change details

Add handlers under Application.Meetings for following events:

  • application/vnd.microsoft.meetingStart
  • application/vnd.microsoft.meetingEnd
  • application/vnd.microsoft.meetingParticipantJoin
  • application/vnd.microsoft.meetingParticipantLeave

Refactor InvokeActivityUtilities to ActivityUtilities since the event activity has Activity.Value as well.

Unit tests.

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

@swatDong swatDong marked this pull request as ready for review November 3, 2023 05:16
@swatDong swatDong requested a review from corinagum November 3, 2023 05:16
@swatDong swatDong merged commit 90463d7 into dotnetfluent Nov 6, 2023
5 checks passed
@swatDong swatDong deleted the qidon/meeting branch November 6, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants