Skip to content

OSC 52: Gate clipboard writes on focus to prevent background clipboard hijacking #19357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+16 −3
Open

OSC 52: Gate clipboard writes on focus to prevent background clipboard hijacking #19357

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac96872
OSC 52: Gate clipboard writes on focus to prevent background clipboar…
DivInstance Sep 17, 2025
6253199
Add check in FocusChanged to avoid redundant HandleFocus calls
DivInstance Sep 19, 2025
513606d
Secure OSC 52 clipboard operations in conhost with focus check
DivInstance Sep 19, 2025
f459e51
Format files, Revert unrelated changes
lhecker Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/cascadia/TerminalCore/Terminal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,7 @@ TerminalInput::OutputType Terminal::SendCharEvent(const wchar_t ch, const WORD s
// - none
TerminalInput::OutputType Terminal::FocusChanged(const bool focused)
{
_isFocused = focused;
return _getTerminalInput().HandleFocus(focused);
Copy link
Member

@lhecker lhecker Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a if (_isFocused != focused) here, if we're at it? This would prevent accidental, redundant HandleFocus calls.

Copy link
Author

@DivInstance DivInstance Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I’ve added the optimization and pushed it to the PR.

}

Expand Down
1 change: 1 addition & 0 deletions src/cascadia/TerminalCore/Terminal.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,7 @@ class Microsoft::Terminal::Core::Terminal final :
til::CoordType _scrollbackLines = 0;
bool _detectURLs = false;
bool _clipboardOperationsAllowed = true;
bool _isFocused = false;

til::size _altBufferSize;
std::optional<til::size> _deferredResize;
Expand Down
3 changes: 2 additions & 1 deletion src/cascadia/TerminalCore/TerminalApi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ unsigned int Terminal::GetInputCodePage() const noexcept

void Terminal::CopyToClipboard(wil::zwstring_view content)
{
if (_clipboardOperationsAllowed)
// Only allow VT clipboard writes when the terminal has focus
if (_clipboardOperationsAllowed && _isFocused)
{
_pfnCopyToClipboard(content);
}
Expand Down