Unblock run when cancellation was requested #5267
Conversation
| // They will still run on background but we won't await them. | ||
| var runCancelled = new TaskCompletionSource<object>(); | ||
| _testRunCancellationToken?.Register(() => runCancelled.TrySetCanceled()); | ||
| await Task.WhenAny(Task.WhenAll(tasks), runCancelled.Task); |
There was a problem hiding this comment.
Cancellation token _testRunCancellationToken is not a CancellationToken, so we cannot use Task.WhenAll(tasks, ct) here.
| string fileCreationPath = Path.Combine(testHost.DirectoryName, "fileCreation"); | ||
| File.WriteAllText(fileCreationPath, string.Empty); |
There was a problem hiding this comment.
This was unblocking the loop below, so as soon as we started the app we cancelled tests before any test ever had a chance to run.
So this test was testing almost nothing.
|
|
||
| testHostResult.AssertOutputMatchesRegex("Canceling the test session.*"); |
There was a problem hiding this comment.
Now we abort so fast that this does not have a chance to write to screen.
| await ExecuteTestsWithTestRunnerAsync(nonParallelizableTestSet, frameworkHandle, source, sourceLevelParameters, testRunner, usesAppDomains); | ||
| } | ||
| } | ||
| else | ||
| { | ||
| // What to do? |
There was a problem hiding this comment.
Here and few lines above we run the tests when parallelization is not enabled or test is marked with do not parallelize, this blocks the cancellation until the test finishes (and fails the non-parallel tests), and advice here how elegantly solve this? (it won't block if we have parallelism with 1 worker, because that takes the other parallel path.
There was a problem hiding this comment.
@nohwnd How does it block cancellation? ExecuteTestsWithTestRunnerAsync calls ThrowIfCancellationRequested
There was a problem hiding this comment.
Yes but only before it starts running the test. if we cancel while the test is running we don't have a way to abandon it to background and continue to test run teardown code. Like writing test summary to screen. We still have 1 tests in progress and wait for it to complete.
There was a problem hiding this comment.
You can still do the same Task.WhenAny trick right?
Ensure that we can complete the run when non-graceful cancellation is requested (e.b. ctrl+C on commandline), by making sure that the test runner does not wait for all currently running tests to finish.